Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): create a pipeline for linting YAML workflow files #2183

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Dec 31, 2024

Description

Created a workflow file for linting GitHub Actions workflow files during pull requests and pushes to master.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

Additional Information

Include any additional information that you think is necessary for this pull request, including screenshots of the changes that you have made.

@nicomiguelino nicomiguelino marked this pull request as ready for review January 1, 2025 04:59
@nicomiguelino nicomiguelino requested a review from a team as a code owner January 1, 2025 04:59
Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Contributor Author

@nicomiguelino nicomiguelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a self-review

Comment on lines +36 to +42
echo "buildx_args=\
--cache-from \"screenly/ose-qt-builder:latest\" \
--output \"type=image,push=true\" \
--build-arg \"BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')\" \
--build-arg \"GIT_HASH=$GITHUB_SHA\" \
--build-arg \"GIT_SHORT_HASH=$(git rev-parse --short HEAD)\" \
--build-arg \"GIT_BRANCH=$GITHUB_REF_NAME\"" >> "$GITHUB_OUTPUT"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check if this really works.

@@ -49,7 +49,7 @@ jobs:
python bin/build-pi-imager-json.py > _site/rpi-imager.json

# Make sure it's valid
cat _site/rpi-imager.json | jq
jq . < _site/rpi-imager.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check if it still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Code Review
Development

Successfully merging this pull request may close these issues.

1 participant