fix: don't crash on bad manifest

ScrappySM · Jan 16, 2025 · b6ecff3 · b6ecff3
1 parent f40962c
commit b6ecff3
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/CarbonLauncher/src/modmanager.cpp b/CarbonLauncher/src/modmanager.cpp
@@ -81,7 +81,15 @@ std::optional<Mod> ModManager::JSONToMod(const nlohmann::json& jMod) {
 
 	if (hasManifest) {
 		spdlog::trace("Mod {} has a manifest.json!", ghUser + "/" + ghRepo);
-		auto jManifest = nlohmann::json::parse(manifest.text);
+		//auto jManifest = nlohmann::json::parse(manifest.text);
+		nlohmann::json jManifest;
+		try {
+			jManifest = nlohmann::json::parse(manifest.text);
+		}
+		catch (nlohmann::json::parse_error& e) {
+			spdlog::error("Failed to parse JSON: {}", e.what());
+			return std::nullopt;
+		}
 
 		mod.name = jManifest["name"];
 		mod.authors = jManifest["authors"].get<std::vector<std::string>>();