Map almost closed view #545
Open
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Places that close soon are now yellow on the map, and the rest are red and green as usual. This way, the list view matches the map.
CMU Concept restaurants that close soon are now yellow on the map, and the rest are red and green as usual, depending on if they are open or closed. This way, the list view matches the map. Before, restaurants that appeared yellow on the list were green on the map.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cirex-web
reviewed
Feb 2, 2025
Comment on lines
+72
to
+81
| let markerColor = '#ff5b40'; | ||
| if (location.closedLongTerm) { | ||
| markerColor = '#ff5b40'; | ||
| } else if ( | ||
| location.locationState === LocationState.CLOSES_SOON | ||
| ) { | ||
| markerColor = '#ffd700'; | ||
| } else if (location.isOpen) { | ||
| markerColor = '#69bb36'; | ||
| } |
There was a problem hiding this comment.
Thanks!
I think we can probably directly call
const colors: Record<LocationState, string> = {
[LocationState.OPEN]: '#19b875',
[LocationState.CLOSED]: '#dd3c18',
[LocationState.CLOSED_LONG_TERM]: '#dd3c18',
[LocationState.OPENS_SOON]: '#f6cc5d',
[LocationState.CLOSES_SOON]: '#f3f65d',
};defined in EateryCard.tsx for the values instead. Is there any reason why the colors need to be different between the two pages?
At this point, maybe we should honestly create a new file /util/colors.ts and write a getColorFromStatus function that uses this colors map.
There was a problem hiding this comment.
or, or, better yet, make some css classes like .icon--closes-soon, .icon--opens-soon, .icon--closed and delegate the color assignment responsibility to CSS instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMU Concept restaurants that close soon are now yellow on the map, and the rest are red and green as usual, depending on if they are open or closed. This way, the list view matches the map. Before, restaurants that appeared yellow on the list were green on the map.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: