-
-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qrencode: Add version 4.1.1 #3754
Conversation
/verify |
Is there any indication that the GitHub repo and SourceForge repo are officially related? |
No, but it's the only available source. I guess it's similar to Should I use |
Checking https://sourceforge.net/p/qrencode-for-windows/tickets/1/, I'm skeptical about the author releasing any 64bit binaries, or worse, any versions newer than 4.1.1 (when they come at the GitHub repo)... |
Switched to using Not putting 32-bit binaries as support has already been dropped for 32-bit MSYS2 (https://www.msys2.org/news/#2020-05-17-32-bit-msys2-no-longer-actively-supported). |
a0d5e71
to
c41e12a
Compare
/verify |
Your changes do not pass checks. qrencode
|
/verify |
All changes look good. Wait for review from human collaborators. qrencode
|
PNG output seems to be disabled, which is available in the MinGW version (msys2/MSYS2-packages#2214). But the MinGW version cannot display utf8 correctly. I guess that is more important, and you can alternatively export it to SVG and use something like ImageMagick or Inkscape to convert it to a PNG. |
I did some testing around: msys2/MSYS2-packages#2214 (comment) |
Mingw or msys 🤔 |
Mingw (you can check the command's path, it starts with Msys2 commands start with |
I mean, I was wondering what to use for this manifest, considering the drawbacks of each option 😅 |
The mingw one has multiple dependencies so it'll be very difficult to manage. Hmm, I guess the current manifest (msys2) is our only option now... |
A quick look using dependencies tells us otherwise: |
Commonly used CLI utility to generate QR Codes from text.