Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qrencode: Add version 4.1.1 #3754

Merged
merged 6 commits into from
Jul 17, 2022
Merged

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jul 16, 2022

Commonly used CLI utility to generate QR Codes from text.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 16, 2022

/verify

@rashil2000
Copy link
Member

Is there any indication that the GitHub repo and SourceForge repo are officially related?

@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

Is there any indication that the GitHub repo and SourceForge repo are officially related?

No, but it's the only available source. I guess it's similar to grep, which gets its source from the chocolatey package, which gets it from https://github.com/mbuilov/grep-windows/.

Should I use mingw-w64-qrencode from msys2 instead? That one has multiple dependencies and would be hard to manage. Or libqrencode, which would only depend on msys2-runtime.

@rashil2000
Copy link
Member

Checking https://sourceforge.net/p/qrencode-for-windows/tickets/1/, I'm skeptical about the author releasing any 64bit binaries, or worse, any versions newer than 4.1.1 (when they come at the GitHub repo)...

@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

Switched to using libqrencode from msys2. Additionally, that version does not print garbage on utf8 and ansi compared to the mingw-w64 and msvc versions (fukuchi/libqrencode#200)

Not putting 32-bit binaries as support has already been dropped for 32-bit MSYS2 (https://www.msys2.org/news/#2020-05-17-32-bit-msys2-no-longer-actively-supported).

@sitiom sitiom force-pushed the qrencode branch 2 times, most recently from a0d5e71 to c41e12a Compare July 17, 2022 10:18
@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

qrencode

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

qrencode

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

PNG output seems to be disabled, which is available in the MinGW version (msys2/MSYS2-packages#2214). But the MinGW version cannot display utf8 correctly. I guess that is more important, and you can alternatively export it to SVG and use something like ImageMagick or Inkscape to convert it to a PNG.
image

@rashil2000
Copy link
Member

I did some testing around: msys2/MSYS2-packages#2214 (comment)

@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

Mingw or msys 🤔

@rashil2000
Copy link
Member

rashil2000 commented Jul 17, 2022

Mingw (you can check the command's path, it starts with /mingw64/bin)

Msys2 commands start with /usr/bin

@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

I mean, I was wondering what to use for this manifest, considering the drawbacks of each option 😅

@rashil2000
Copy link
Member

The mingw one has multiple dependencies so it'll be very difficult to manage.

Hmm, I guess the current manifest (msys2) is our only option now...

@rashil2000 rashil2000 merged commit 40f5fe0 into ScoopInstaller:master Jul 17, 2022
@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

The mingw one has multiple dependencies so it'll be very difficult to manage.

I'm more inclined to switch to MinGW as it is future-proof (The latest Windows Terminal preview works, conhost might be fixed), has png support, has a smaller file size, and has 32-bit builds.

Is it also possible that other sub-dependencies are also introduced due to some dependencies bundling their own tools? I have reduced the dependencies to just libpng, libwinpthread, and zlib in a Sandbox and it seems to work:
image

@sitiom sitiom deleted the qrencode branch July 17, 2022 13:50
@sitiom
Copy link
Contributor Author

sitiom commented Jul 17, 2022

A quick look using dependencies tells us otherwise:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants