Ignore unknown events in the client, at deserialization. #9471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AureliaDolo
force-pushed
the
aurelia/ignore_unknown_events
branch
from
246118a to
dbf6acb
Compare
FirelightFlagboy
approved these changes
Jan 30, 2025
libparsec/crates/client_connection/src/authenticated_cmds/sse.rs
Outdated
Show resolved
Hide resolved
AureliaDolo
force-pushed
the
aurelia/ignore_unknown_events
branch
from
dbf6acb to
2481da7
Compare
vxgmichel
approved these changes
Jan 31, 2025
| match T::api_load_response(raw.as_ref()) { | ||
| Ok(cooked) => SSEResponseOrMissedEvents::Response(cooked), | ||
| Err(e) => { | ||
| log::trace!("Invalid event data: {e}"); |
There was a problem hiding this comment.
Maybe use a log::warn!() since it's a useful information to know?
| Ok(cooked) => SSEResponseOrMissedEvents::Response(cooked), | ||
| Err(e) => { | ||
| log::trace!("Invalid event data: {e}"); | ||
| // we ignore bad deserialization |
There was a problem hiding this comment.
Could you explain in this comment that ignoring a bad deserialization error is useful to not break compatibility when new event types are added to our protocol?
Also comments should start with a capitalized letter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9410
The added test case fails with BadContent without the patch.