Skip to content

Commit

Permalink
Fixed various warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Ironicbay committed Apr 26, 2024
1 parent d0d2ec9 commit 94264e5
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 12 deletions.
11 changes: 10 additions & 1 deletion src/locales/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@
}
},
"sorter": {
"title": "Sorter"
"title": "Sorter",
"name": "Name",
"birthDate": "Birth date",
"age": "Age"
},
"spinner": {
"title": "Spinner"
Expand All @@ -62,6 +65,12 @@
},
"gridListToggle": {
"title": "Grid list toggle"
},
"msReportTheme": {
"info": "Info",
"warning": "Warning",
"error": "Error",
"success": "Success"
}
}
},
Expand Down
11 changes: 10 additions & 1 deletion src/locales/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@
}
},
"sorter": {
"title": "Sorter"
"title": "Sorter",
"name": "Nom",
"birthDate": "Date de naissance",
"age": "Âge"
},
"spinner": {
"title": "Spinner"
Expand All @@ -62,6 +65,12 @@
},
"gridListToggle": {
"title": "Grid list toggle"
},
"msReportTheme": {
"info": "Info",
"warning": "Alerte",
"error": "Erreur",
"success": "Succès"
}
}
},
Expand Down
20 changes: 10 additions & 10 deletions src/views/HomePage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@
v-for="item in msSorterExampleData"
:key="item.name"
>
<ion-label>name: {{ item.name }}</ion-label>
<ion-label>birth date: {{ I18n.formatDate(item.birthDate, 'short') }}</ion-label>
<ion-label>age: {{ item.age }}</ion-label>
<ion-label>{{ $msTranslate('usage.components.sorter.name') }}: {{ item.name }}</ion-label>
<ion-label>{{ $msTranslate('usage.components.sorter.birthDate') }}: {{ $msTranslate(I18n.formatDate(item.birthDate, 'short')) }}</ion-label>
<ion-label>{{ $msTranslate('usage.components.sorter.age') }}: {{ item.age }}</ion-label>
</div>
</div>
</ion-item-divider>
Expand Down Expand Up @@ -193,19 +193,19 @@ import SettingsModal from './settings/SettingsModal.vue';
const msDropdownOptions: MsOptions = new MsOptions([
{
key: MsReportTheme.Info,
label: 'MsReportTheme.Info',
label: 'usage.components.msReportTheme.info',
},
{
key: MsReportTheme.Warning,
label: 'MsReportTheme.Warning',
label: 'usage.components.msReportTheme.warning',
},
{
key: MsReportTheme.Error,
label: 'MsReportTheme.Error',
label: 'usage.components.msReportTheme.error',
},
{
key: MsReportTheme.Success,
label: 'MsReportTheme.Success',
label: 'usage.components.msReportTheme.success',
},
]);
Expand All @@ -216,9 +216,9 @@ const displayView = ref(DisplayState.List);
const msReportTheme = ref(MsReportTheme.Info);
const msSorterOptions: MsOptions = new MsOptions([
{ label: 'name', key: 'name' },
{ label: 'birth date', key: 'birthDate' },
{ label: 'age', key: 'age' },
{ label: 'usage.components.sorter.name', key: 'name' },
{ label: 'usage.components.sorter.birthDate', key: 'birthDate' },
{ label: 'usage.components.sorter.age', key: 'age' },
]);
const msSorterLabels = {
Expand Down

0 comments on commit 94264e5

Please sign in to comment.