Added a ci-wheels yml #135
Conversation
There was a problem hiding this comment.
Hi @ESadek-MO, I think this needs another look.
Largely taken from python-stratify, with a couple continuity changes.
python-stratify is not the right model for tephi, since stratify includes Cython and therefore needs to publish OS-specific builds (the job of cibuildwheel). I'd suggest looking at Iris, iris-esmf-regrid and nc-time-axis for an idea of how this workflow should be.
| # - https://github.com/actions/checkout | ||
| # - https://github.com/actions/download-artifact | ||
| # - https://github.com/actions/upload-artifact | ||
| # - https://github.com/pypa/cibuildwheel |
There was a problem hiding this comment.
You're not using cibuildwheel
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
It looks like Tephi is agnostic to OS - there are no OS-specific files here:
https://pypi.org/project/tephi/#files 1
So the matrix should be unnecessary. E.g. ci-wheels.yml in Iris does not have one.
Footnotes
| - "v*" | ||
|
|
||
| jobs: | ||
| build_bdist: |
There was a problem hiding this comment.
This job is not currently creating a built distribution ("bdist") - it only has 1 step - checking out the repo.
| path: ${{ github.workspace }}/dist/*.tar.gz | ||
|
|
||
|
|
||
| show-artifacts: |
There was a problem hiding this comment.
Several other repos include a test stage. Looks like they download the artifacts and make sure that each provides a functional instance of the package.
Repos with this:
- Iris
- Iris-esmf-regrid
- nc-time-axis
Repos without this:
- Stratify
- cf-units
It looks like the only times that we skip this are for repos that include Cython (and therefore build using cibuildwheel). Tephi is not in this camp, so could it include a testing stage?
| name: "Publish to Test PyPI" | ||
| runs-on: ubuntu-latest | ||
| # upload to Test PyPI for every commit on main branch | ||
| if: github.event_name == 'push' && github.event.ref == 'refs/heads/main' |
There was a problem hiding this comment.
In other repos you have suggested a check for the repository owner, too: SciTools/iris#5180. Can that be included here too?
| @@ -10,5 +10,4 @@ requires = [ | |||
| "wheel", | |||
| ] | |||
| # Defined by PEP 517 | |||
| build-backend = "setuptools.build_meta" | |||
|
|
|||
| build-backend = "setuptools.build_meta" | |||
There was a problem hiding this comment.
This change looks unintended
Largely taken from python-stratify, with a couple continuity changes.
This might need a careful eye, it was largely trial and error.