Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guidelines in line with v5 SciTools CLA #192

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

See SciTools/.github#19 for more details - saves me writing it out multiple times!

@spencerkclark @aulemahal you have been very kind to contribute so much time to nc-time-axis, but this is probably the first you are hearing about the CLA changes. Please take a moment to make sure you are comfortable; I don't imagine this PR moving until 2024.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0594c9b) 97.36% compared to head (43cde7c) 97.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files           7        7           
  Lines         644      644           
=======================================
  Hits          627      627           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ESadek-MO ESadek-MO self-assigned this Feb 22, 2024
Copy link

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @trexfeathers

@ESadek-MO ESadek-MO merged commit 9087f43 into SciTools:main Feb 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants