Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt repo-review pre-commit hook #456

Merged
merged 1 commit into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ repos:
hooks:
- id: validate-pyproject

- repo: https://github.com/scientific-python/cookie
rev: 2024.03.10
hooks:
- id: sp-repo-review
additional_dependencies: ["repo-review[cli]"]
args: ["--show=errskip"]

# TODO: pending the addition of numpydoc, including config file(s).
#- repo: https://github.com/numpy/numpydoc
# rev: v1.7.0
Expand Down
13 changes: 13 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ ignore = [
# See https://mypy.readthedocs.io/en/stable/config_file.html
ignore_missing_imports = true
warn_unused_configs = true
warn_unreachable = true
pp-mo marked this conversation as resolved.
Show resolved Hide resolved
enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
exclude = [
'noxfile\.py',
Expand All @@ -133,6 +134,18 @@ minversion = "6.0"
testpaths = "src/iris_grib"
xfail_strict = "True"

[tool.repo-review]
ignore = [
# https://learn.scientific-python.org/development/guides/style/#MY102
"MY102", # MyPy show_error_codes deprecated
# https://learn.scientific-python.org/development/guides/style/#PC170
"PC170", # Uses PyGrep hooks
# https://learn.scientific-python.org/development/guides/style/#PC180
"PC180", # Uses prettier
# https://learn.scientific-python.org/development/guides/pytest/#PP309
"PP309", # Filter warnings specified
]

[tool.ruff]
# Exclude the following, in addition to the standard set of exclusions.
# https://docs.astral.sh/ruff/settings/#exclude
Expand Down
Loading