-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added in linkchecks and coverage checks for gha ci #432
Conversation
Readded in a couple of links to be ignored: https://software.ecmwf.int/ is no longer correct, https://confluence.ecmwf.int/ is, however it doesn't seem to have a landing page for GRIB. I'm ignoring any errors in release notes atm, as it seems questionable to maintain that, but that might want to be discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The coverage is not completed nor working |
@bjlittle Is it just not running in the CI at all then? I've had coverage problems in iris-esmf-regrid also, but they've been causing CI failures. |
Seems like the |
Also, if it was working, I suspect tokens require to be also configured. |
yeah, I suspect I'll need to sort out tokens for iris-esmf-regrid also |
Not sure I follow exactly (I'm a bit rusty on this), but I think we can get around to this in due course. |
Closes #340.
Finishes work started in #415.