Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: unintended conversion of float to numpy.float64 #2473

Closed
wants to merge 2 commits into from

Conversation

juhi24
Copy link

@juhi24 juhi24 commented Nov 4, 2024

Rationale

Fix #2472

Implications

I believe this is how the original authors intended it. I believe the only implication should be fixing the reported bug, i.e. avoiding unwanted type conversion.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

greglucas
greglucas previously approved these changes Nov 4, 2024
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an issue upstream with fetch_raster and their Java implementation not handling/converting numpy datatypes. This seems simple enough though that we can easily add it.

I'm not sure there is a great test we could add here, so maybe just a comment would be helpful explaining why we are doing this?

lib/cartopy/mpl/slippy_image_artist.py Show resolved Hide resolved
@juhi24
Copy link
Author

juhi24 commented Nov 11, 2024

The #2472 was fixed upstream. The fix proposed in this PR is not strictly necessary. It's now a guestion between little added robustness and simplicity. May the maintainers decide.

@greglucas greglucas dismissed their stale review November 11, 2024 15:39

Fixed upstream, so this is unnecessary here now.

@greglucas
Copy link
Contributor

Because this is fixed upstream, I do not think we should add it here anymore, that is adding an extra calculation that isn't needed. Thanks for following up and getting it fixed upstream!

@juhi24 juhi24 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMS rendering: Bounding box coordinate 0 is not parsable:np.float64
3 participants