review: update disabled typings and remove todos

SchwarzIT · Jan 17, 2025 · 6ffb13c · 6ffb13c
1 parent ab7d543
commit 6ffb13c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/sit-onyx/src/components/OnyxSelect/OnyxSelect.vue b/packages/sit-onyx/src/components/OnyxSelect/OnyxSelect.vue
@@ -415,17 +415,14 @@ defineExpose({ input: computed(() => selectInput.value?.input) });
               >
                 {{ group }}
               </li>
-
-              <!-- TODO: remove type cast once its fixed in Vue / vue-tsc version -->
               <OnyxSelectOption
                 v-for="option in groupOptions"
                 :key="option.value.toString()"
                 v-bind="
                   headlessOption({
                     value: option.value,
                     label: option.label,
-                    disabled: option.disabled as any,
-                    // TODO: remove type cast once its fixed in Vue / vue-tsc version
+                    disabled: option.disabled,
                     selected: arrayValue.some((value: TValue) => value === option.value),
                   })
                 "

diff --git a/packages/sit-onyx/src/components/OnyxSelect/types.ts b/packages/sit-onyx/src/components/OnyxSelect/types.ts
@@ -82,9 +82,13 @@ export type OnyxSelectProps<
 
 export type SelectOption<TValue extends SelectOptionValue = SelectOptionValue> = Pick<
   BaseSelectOption<TValue>,
-  "value" | "label" | "disabled" | "truncation"
+  "value" | "label" | "truncation"
 > &
   Pick<OnyxSelectOptionProps, "icon"> & {
+    /**
+     * Disables the option and prevents it from being selected.
+     */
+    disabled?: boolean;
     /**
      * Optional group name. If set, all options with the same group name will be grouped below that name.
      * If `group` is used for one option, it should be used for all other options as well.