Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct INSTALL_DIR for brew installation #1362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zeroberry
Copy link

fixes #824, #1190, #1194, #1237, #1279

On macOS, when you install fnm using Homebrew, the installation directory ends up being something like /usr/local/opt/fnm or /opt/homebrew/opt/fnm instead of $HOME/.fnm, $XDG_DATA_HOME/fnm, $HOME/Library/Application Support/fnm.

I updated INSTALL_DIR to match the correct location for Homebrew installations. Also, since Homebrew takes care of the PATH automatically, export PATH step is removed.

Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: 924078d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 3:13pm

@ericbdev
Copy link

ericbdev commented Jan 8, 2025

<3 I've literally just sorted this out in my own system when the readme instructions didn't work.

@kaaax0815
Copy link

kaaax0815 commented Jan 9, 2025

If you just install using brew install fnm (which the install script is doing) no additional config is required other then adding something like

eval "$(fnm env --use-on-cd --version-file-strategy=recursive)"

to your .zshrc

as brew automatically adds

eval "$(/opt/homebrew/bin/brew shellenv)"

to your .zprofile which adds /opt/homebrew/bin to your path. and by installing fnm, brew adds a symlink to the correct binary already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node: command not found on MacOS 12
3 participants