Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prometheus fallback_scrape_protocol support #4373

Merged
merged 4 commits into from
Jan 21, 2025
Merged

feat: prometheus fallback_scrape_protocol support #4373

merged 4 commits into from
Jan 21, 2025

Conversation

KetchupBomb
Copy link
Contributor

Addresses #4372

@KetchupBomb KetchupBomb marked this pull request as ready for review January 21, 2025 04:34
@hyperupcall
Copy link
Member

Thanks - CI seems to be failing from pre-commit.ci. If you'd like, you can use an enum to narrow the valid cases of the property instead of writing it out

@hyperupcall
Copy link
Member

Sweet thanks

@hyperupcall hyperupcall merged commit db84bf0 into SchemaStore:master Jan 21, 2025
3 checks passed
@KetchupBomb KetchupBomb mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madskristensen madskristensen Awaiting requested review from madskristensen madskristensen is a code owner

@hyperupcall hyperupcall Awaiting requested review from hyperupcall hyperupcall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KetchupBomb @hyperupcall