Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
SchabanBo committed Jul 30, 2024
1 parent 8dc9312 commit 088a3d7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/src/controllers/match_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class MatchController {
}
QR.log(
// ignore: lines_longer_than_80_chars
'${'Finding Match for $sPath under '}${foundPath.isEmpty ? 'root' : 'path $foundPath'}');
'${'Finding Match for $sPath under '}${foundPath.isEmpty ? 'root' : 'path $foundPath'} with params $params');
}

factory MatchController.fromName(
Expand Down
1 change: 1 addition & 0 deletions lib/src/qr_navigation.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ extension QRNavigation on QRContext {

/// try to pop the last active navigator or go to last path in the history
Future<PopResult> back([dynamic result]) async {
log('Back to previous path');
if (history.isEmpty) return PopResult.NotPopped;

// is processed by declarative
Expand Down
2 changes: 1 addition & 1 deletion lib/src/routers/temporary_router.dart
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class _TemporaryQRouterState extends State<TemporaryQRouter> {
QR.activeNavigatorName = QRContext.rootRouterName;
_treeAdjuster.reset();
WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
QR.updateUrlInfo(originalRoute, addHistory: false);
QR.updateUrlInfo(originalRoute);
});
}

Expand Down
1 change: 1 addition & 0 deletions test/scenario-code/temporary_router_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import '../helpers.dart';

void main() {
testWidgets('Test Temporary router', (tester) async {
QR.reset();
tester.view.devicePixelRatio = 1.0;
tester.view.physicalSize = const Size(400, 600);
addTearDown(tester.view.resetPhysicalSize);
Expand Down

0 comments on commit 088a3d7

Please sign in to comment.