fix: allow dictionary values to be empty #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #2 addressing only the value part of it.
I've encountered a lot of empty values in dictionaries in the wild, which currently breaks parsing. The fix here is to simply make dictionary values "zero or more", as specified in Bruno's grammar.
Making dictionary keys (and assert keys) zero or more is much more problematic, it leads to tons of parsing errors. I found through trial and error that marking them as optional instead appears to work fine, but then you end up with dictionary pairs that lack keys in the syntax tree which also isn't quite right.
Anyway, just having the value be zero or more characters solves my current issue, I just have a lot of empty values in files I'm working with.