[ISSUES#394]Update Snfoundry package to support starknet foundry script #426

847850277 · 2025-01-21T14:09:03Z

PR description

Currently, we can use yarn deploy&&yarn deploy -- network sepolia.
but there has some problem need to solve.
the problem is cairo script ``declare` can not get class_hash when the contract has been already declared.
it will return

{
  "version": 1,
  "transactions": {
    "transactions": {
      "196d86c22d6bd216c4c0497de3f9aa008a298f36478e25b7225a84ddc84c6643": {
        "name": "declare",
        "output": {
          "type": "ErrorResponse",
          "message": "Transaction already exists"
        },
        "status": "Error",
        "timestamp": 1737548319,
        "misc": null
      }
    }
  }
}

u can check out and go to folder packages/test_2/scripts execute
sncast --account account-1 script run my_script --url https://starknet-sepolia.public.blastapi.io/rpc/v0_7 recurrent it.

or u can read packages/snfoundry/scripts/readme.md.

Fixes #394

Types of change

Feature
Bug
Enhancement

Comments (optional)

Co-authored-by: root <root@Hp-pavilion>

Co-authored-by: Gianfranco99 <gianfranco.benvenuto99gmail.com>

…ct (Scaffold-Stark#312)[skip ci]

… [skip ci] Co-authored-by: metalboyrick <[email protected]>

…[skip ci]

…skip ci]

…pulate issue (Scaffold-Stark#332)

This reverts commit d229d47.

This reverts commit f95a0fa.

Scaffold-Stark#339)

Co-authored-by: Quantum3Labs <[email protected]>

…old-Stark#334) Co-authored-by: iossocket <[email protected]>

gianalarcon · 2025-01-22T03:21:18Z

packages/snfoundry/.env.example

@@ -1,8 +1,8 @@
 # ## Devnet


is it necessary to change this flie?

gianalarcon · 2025-01-25T12:20:53Z

PR ready for review @jrcarlos2000 @Nadai2010

…caffold-Stark#430)[skip ci]

Co-authored-by: GianMarco <[email protected]>

gianalarcon · 2025-02-10T18:10:53Z

Hi @847850277 , your PR should point to starknet-foundry branch, not to main, pls fix it. Thank you so much

# Conflicts: # packages/snfoundry/.env.example # packages/snfoundry/Scarb.toml # packages/snfoundry/contracts/src/lib.cairo # packages/snfoundry/package.json # packages/snfoundry/scripts-ts/helpers/command.ts # packages/snfoundry/scripts/Scarb.lock # packages/snfoundry/scripts/Scarb.toml # packages/snfoundry/scripts/src/lib.cairo # packages/snfoundry/src/test/TestContract.cairo # yarn.lock

Nadai2010

Thank you very much for the contribution, good job, there are several details to fix before the merged to the sn-foundry branch.

Nadai2010 · 2025-02-11T14:18:36Z

packages/snfoundry/.env.example

This file should not change

Nadai2010 · 2025-02-11T14:20:11Z

packages/snfoundry/Scarb.toml

 casm = true
-
-[workspace]
-members = ["scripts"]


I think you should keep the sricpt to point to the new scarb.

Nadai2010 · 2025-02-11T14:22:09Z

packages/snfoundry/package.json

@@ -3,7 +3,7 @@
  "version": "0.0.1",
  "scripts": {
    "chain": "starknet-devnet --seed 0 --account-class cairo1",
-    "deploy": "ts-node scripts-ts/helpers/deploy-wrapper.ts",
+    "deploy": "ts-node ./scripts-ts/helpers/command.ts deploy",


If the main idea is to keep it in a branch snfoundry, wouldn't it be better to add it as a different deploy or adjust as you are doing

What do you think @jrcarlos2000 ?

Nadai2010 · 2025-02-11T14:30:04Z

packages/snfoundry/scripts/readme.md

+```
+
+
+## current may Troubled problem


This is one of the main problems when integrating in the main, we must have it under control, once it is solved we could revaluate

yes! It must be resolved, otherwise using cairo's dacare&&deploy in already declared scenarios will block it.

but sncast_std seem not support return class_hash when declared exist.

omsant02 and others added 30 commits October 2, 2024 11:14

Fix/mobile navbar Scaffold-Stark#283 (Scaffold-Stark#299) [skip ci]

1be995f

Co-authored-by: root <root@Hp-pavilion>

feat: Add verification contract command (Scaffold-Stark#298) [skip ci]

a1b117e

Update dApp sample, refactor contract (Scaffold-Stark#305)

9705812

[FEAT] Move "Configure Contracts" to page bottom (Scaffold-Stark#303)

cd6e31d

Co-authored-by: Gianfranco99 <gianfranco.benvenuto99gmail.com>

Update .tool-versions (Scaffold-Stark#306)(skip ci)

a84e277

test: implement test for useAutoConnect.ts (Scaffold-Stark#309)(skip ci)

e5dc4bf

Test: Add unit test for useScaffoldContract and useScaffoldReadContra…

0865d93

…ct (Scaffold-Stark#312)[skip ci]

feat: set autoConnet() expiry time (Scaffold-Stark#307)

e37b20f

test: create test for useScaffoldWriteContract hook (Scaffold-Stark#316)

94327c7

Remove unnecessary files (Scaffold-Stark#317)[skip ci]

6a8af0b

Remove import unnecessary (Scaffold-Stark#318) [skip ci]

2c9d168

Add yarn deploy --noreset and modify yarn deploy (Scaffold-Stark#321)…

1a4abd0

… [skip ci] Co-authored-by: metalboyrick <[email protected]>

fix: wrong variables in scaffold write contract (Scaffold-Stark#323) …

8c90f64

…[skip ci]

hotfix: remove console log (Scaffold-Stark#324) [skip ci]

bc26d24

fix: use read contract watch mode does not work (Scaffold-Stark#325)[…

5ae732f

…skip ci]

fix: write hooks parser workaround (Scaffold-Stark#329)

d258d60

Solution in event issue (Scaffold-Stark#331)

f343e25

fix: useScaffoldMultiWriteContract just in time parsing to solve po…

ed0f216

…pulate issue (Scaffold-Stark#332)

New Scaffold V3

d229d47

Revert "New Scaffold V3"

f95a0fa

This reverts commit d229d47.

"Scaffold V3""

7b0e55f

This reverts commit f95a0fa.

Revert commit

731903a

fix: auto connect fix (Scaffold-Stark#333)

3253cc8

Add unit test to useScaffoldEventHistory & use starkjs to parse event. (

4e9a63f

Scaffold-Stark#339)

Avoid export contracts when reverted (Scaffold-Stark#336)

e53fc15

Co-authored-by: Quantum3Labs <[email protected]>

Update release-create-stark.yaml

260a00a

refactor(parser): use starknetjs parsers to encode decode data (Scaff…

cac2446

…old-Stark#334) Co-authored-by: iossocket <[email protected]>

chore(release): 0.3.3 [skip ci]

59d4844

Refactoring parsing logic of contract response (Scaffold-Stark#351)

d72f170

chore(release): 0.3.4 [skip ci]

935c0ca

Buuh2511 and others added 3 commits January 22, 2025 08:24

Upgrade toast (Scaffold-Stark#425)

8257222

chore(release): 0.3.20 [skip ci]

5af2fb3

feat: contract deploy script.

494fd3c

gianalarcon reviewed Jan 22, 2025

View reviewed changes

packages/snfoundry/.env.example Outdated

@@ -1,8 +1,8 @@

# ## Devnet

Copy link

Collaborator

gianalarcon Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to change this flie?

847850277 added 2 commits January 22, 2025 20:54

feat: contract deploy script.

10de039

Merge branch 'main' into issues_394

fbd7461

gianalarcon requested review from jrcarlos2000 and Nadai2010 January 22, 2025 13:17

847850277 added 2 commits January 22, 2025 21:24

feat: contract deploy script delete file.

5ac2e5e

feat: contract deploy script check style.

232fd7a

847850277 marked this pull request as ready for review January 24, 2025 09:14

iossocket and others added 12 commits January 27, 2025 17:39

Option u256 is rendered as u256 in debug ui form (Scaffold-Stark#429)

922f8ee

chore(release): 0.3.21 [skip ci]

86aa1be

chore(docs): fix incorrect Starknet Foundry version in documentation (S…

06cf48e

…caffold-Stark#430)[skip ci]

Keplr connector (Scaffold-Stark#427)

5670537

chore(release): 0.3.22 [skip ci]

a850dca

Cache getClassHash request and result (Scaffold-Stark#433)

3fd4002

chore(release): 0.3.23 [skip ci]

e554410

Update release-create-stark.yaml

cfa08df

Merge branch 'main' into issues_394

aa1d3ff

Improving Test Flow with SNFoundry (Scaffold-Stark#431)

6d18667

Co-authored-by: GianMarco <[email protected]>

chore(release): 0.3.24 [skip ci]

2f4d99c

fix: typos in documentation files (Scaffold-Stark#435)

7ab2a9b

847850277 changed the base branch from main to starknet-foundry February 11, 2025 01:25

847850277 added 2 commits February 11, 2025 11:14

Merge branch 'main' into issues_394

6cbe572

Nadai2010 requested changes Feb 11, 2025

View reviewed changes

feat: update.

1bfe300

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUES#394]Update Snfoundry package to support starknet foundry script #426

[ISSUES#394]Update Snfoundry package to support starknet foundry script #426

847850277 commented Jan 21, 2025 •

edited by gianalarcon

Loading

gianalarcon Jan 22, 2025

gianalarcon commented Jan 25, 2025

gianalarcon commented Feb 10, 2025

Nadai2010 left a comment

Nadai2010 Feb 11, 2025

847850277 Feb 12, 2025

Nadai2010 Feb 11, 2025

847850277 Feb 12, 2025

Nadai2010 Feb 11, 2025

Nadai2010 Feb 11, 2025

847850277 Feb 12, 2025 •

edited

Loading

[ISSUES#394]Update Snfoundry package to support starknet foundry script #426

Are you sure you want to change the base?

[ISSUES#394]Update Snfoundry package to support starknet foundry script #426

Conversation

847850277 commented Jan 21, 2025 • edited by gianalarcon Loading

PR description

Types of change

Comments (optional)

gianalarcon Jan 22, 2025

Choose a reason for hiding this comment

gianalarcon commented Jan 25, 2025

gianalarcon commented Feb 10, 2025

Nadai2010 left a comment

Choose a reason for hiding this comment

Nadai2010 Feb 11, 2025

Choose a reason for hiding this comment

847850277 Feb 12, 2025

Choose a reason for hiding this comment

Nadai2010 Feb 11, 2025

Choose a reason for hiding this comment

847850277 Feb 12, 2025

Choose a reason for hiding this comment

Nadai2010 Feb 11, 2025

Choose a reason for hiding this comment

Nadai2010 Feb 11, 2025

Choose a reason for hiding this comment

847850277 Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

847850277 commented Jan 21, 2025 •

edited by gianalarcon

Loading

847850277 Feb 12, 2025 •

edited

Loading