Update Bug_0xblank

[KevinMB0220]

Address Input Validation Fix

Fixes #345

Types of change

• Bug

Comments (optional)

Fixed a bug where the AddressInput allowed invalid inputs such as 0x.
Now the input is validated to ensure it meets the correct format:

• It must start with 0x.
• It must contain only hexadecimal characters.

If validation fails, an error message is displayed: "Invalid address format".

[metalboyrick]

lets put it in the utils file (i think we have this util already). we don't want duplicates of the same function since they would be a pain to maintain

[KevinMB0220]

I was given another recommendation that 0x be accepted as felt252 and that I should add a 0 to 0x to be accepted

[metalboyrick]

yep, aligned on that end

[metalboyrick]

please make sure 0x0x0 does not work

[KevinMB0220]

Ok I'll check that it aligns with that

[metalboyrick]

seems invalid address still accepted, should not be accepted

expected behavior:

• 0x treated as 0x0
• 0x0x0 should be error
• x0 should be error
• 0x<something> should be correct

[KevinMB0220]

seems invalid address still accepted, should not be accepted

expected behavior:

• 0x treated as 0x0
• 0x0x0 should be error
• x0 should be error
• 0x<something> should be correct

The validation is now ready so that what you requested is not allowed and only valid addresses are allowed.

[Nadai2010]

Hi @KevinMB0220 this is still malfunctioning, can check please? It doesn't do this for me.

[KevinMB0220]

Hi @KevinMB0220 this is still malfunctioning, can check please? It doesn't do this for me.

Ok i check

[metalboyrick]

seems like this is not the spot to fix. might want to take a look at the InputBase and Input component to solve this issue.

[metalboyrick]

@KevinMB0220 what we want to do is to check for the input, not the address display

[KevinMB0220]

@KevinMB0220 what we want to do is to check for the input, not the address display

Can I change something in the faucet since the input address is declared there, so the validation is more direct and functional there?

[metalboyrick]

@KevinMB0220 what we want to do is to check for the input, not the address display

Can I change something in the faucet since the input address is declared there, so the validation is more direct and functional there?

yep sure!

[metalboyrick]

sorry for the long winded review but we need to get this right. Asides from the AddressInput component you would also need to validate the one on the Debug Page (which doesn't use this component)

[metalboyrick]

sorry for the long winded review but we need to get this right. Asides from the AddressInput component you would also need to validate the one on the Debug Page (which doesn't use this component)

i think you can fix the AddressInput component first, let's think about how to abstract the validations to the inputs on the debug page later on (cc @Nadai2010 )

[metalboyrick]

looks good to me!