Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] remove user to prevent ForeignKeyViolation #17534

Open
wants to merge 1 commit into
base: 6.15.z
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/foreman/api/test_ansible.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def _finalize():
@pytest.mark.rhel_ver_match('[78]')
@pytest.mark.tier2
def test_positive_read_facts_with_filter(
self, target_sat, rex_contenthost, filtered_user, module_org, module_location
self, request, target_sat, rex_contenthost, filtered_user, module_org, module_location
):
"""Read host's Ansible facts as a user with a role that has host filter

Expand All @@ -296,6 +296,9 @@ def test_positive_read_facts_with_filter(
host.organization = module_org
host.location = module_location
host.update(['organization', 'location'])
request.addfinalizer(
user.delete
) # Adding a temporary workaround until the issue 'SAT-18656' is resolved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a temporary workaround, why isn't there a condition for that issue being resolved? The same for the original PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier, I tried using the condition, but it didn't work. So, I attempted this approach instead. However, the issue is that this change works sometimes but not consistently. I'm not sure why the behavior varies.


# gather ansible facts by running ansible roles on the host
host.play_ansible_roles()
Expand Down
Loading