Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rhsc7 check from robottelo #17443

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

shweta83
Copy link
Contributor

Problem Statement

rhsc7 repo is removed from constants.py as it is no longer supported in PR but missed removing its check from code.

Solution

Removed the check for rhsc7 and added for rhsc9.

Related Issues

#17421

@shweta83 shweta83 added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Jan 28, 2025
@shweta83 shweta83 requested review from a team January 28, 2025 11:45
@shweta83 shweta83 requested a review from a team as a code owner January 28, 2025 11:45
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_registration.py -k test_host_registration_rex_pull_mode

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9996
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_registration.py -k test_host_registration_rex_pull_mode --external-logging
Test Result : ================= 3 passed, 600 warnings in 5325.26s (1:28:45) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 28, 2025
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 28, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit 3f6b216 into SatelliteQE:master Jan 28, 2025
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 28, 2025
Remove check for rhsc7 from code

(cherry picked from commit 3f6b216)
@lpramuk
Copy link
Contributor

lpramuk commented Jan 29, 2025

@shweta83 Is there a reason why this is not cherrypicked also to 6.15.z and 6.14.z ?

It's failing there. failed on setup with "KeyError: 'rhsc7'"

@shweta83
Copy link
Contributor Author

@shweta83 Is there a reason why this is not cherrypicked also to 6.15.z and 6.14.z ?

It's failing there. failed on setup with "KeyError: 'rhsc7'"

This PR was intended to fix the missed code update done in #17421 and I did not see any PR which removed rhsc7 repo in 6.15.z and 6.14.z.
The repos of rhsc7 are still present in 6.15.z and 6.14.z. It should not fail there. Could you please share the failures link and I will cherrypick these back to the branches.

@lpramuk
Copy link
Contributor

lpramuk commented Jan 29, 2025

Ah that makes sense ! Thanks for explanation @shweta83

I think I have confused 6.16.z w/ 6.15.z. 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants