Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.16.z] check links on EOL banner #17239

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16990

Problem Statement

EOL banner takes a long time to show up (half year before EOL), links contained in the banner can become outdated

Solution

Add checks that links work

Related Issues

awaits SAT-29427
needs
SatelliteQE/airgun#1644

(cherry picked from commit 74ec8bd)
@Satellite-QE Satellite-QE added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Jan 2, 2025
@Satellite-QE Satellite-QE requested a review from a team as a code owner January 2, 2025 13:26
@Satellite-QE Satellite-QE added Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 2, 2025
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py
airgun: 1644

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 2, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9728
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_eol_banner.py --external-logging
Test Result : ================== 1 failed, 9 warnings in 715.34s (0:11:55) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 2, 2025
@pondrejk
Copy link
Contributor

pondrejk commented Jan 2, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9732
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_eol_banner.py --external-logging
Test Result : ================== 1 failed, 9 warnings in 734.75s (0:12:14) ===================

@lhellebr
Copy link
Contributor

lhellebr commented Jan 3, 2025

        # admin can see warning banner
        with Session(test_name, admin_username, admin_password) as adminsession:
            banner = adminsession.eol_banner.read()
            assert message_date in banner["name"]
            assert adminsession.eol_banner.is_warning()
>           check_links(adminsession)

tests/foreman/ui/test_eol_banner.py:85: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

session = <airgun.session.Session object at 0x7f69c10513d0>

    def check_links(session):
>       for link in [session.eol_banner.lifecycle_link(), session.eol_banner.helper_link()]:
E       AttributeError: 'EOLBannerEntity' object has no attribute 'lifecycle_link'

tests/foreman/ui/test_eol_banner.py:33: AttributeError

@pondrejk
Copy link
Contributor

pondrejk commented Jan 6, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9762
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_eol_banner.py --external-logging
Test Result : ================== 1 failed, 9 warnings in 794.09s (0:13:14) ===================

@pondrejk
Copy link
Contributor

pondrejk commented Jan 7, 2025

hm, the results suggest the code changes are not in on the satellite side, will ask around, moving to draft meanwhile

@pondrejk pondrejk marked this pull request as draft January 7, 2025 08:58
@pondrejk pondrejk marked this pull request as ready for review January 14, 2025 09:51
@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9850
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_eol_banner.py --external-logging
Test Result : ================== 1 passed, 9 warnings in 950.79s (0:15:50) ===================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 14, 2025
@Satellite-QE Satellite-QE merged commit b40fe9a into 6.16.z Jan 14, 2025
20 of 24 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-74ec8bd1db8d2282ebdaeea52bafe332ec8bdeee branch January 14, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants