Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test case for the reclaim space warning hiding #16821

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add a test case for the reclaim space warning hiding #16821

merged 1 commit into from
Oct 31, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 30, 2024

Problem Statement

A tiny RFE sneaked in the 6.16.0 and we should rather test its functionality. It's just about hiding the Reclaim space warning on the internal capsule details page via settings.

Solution

This PR proposes a test case for that.

Related Issues

https://issues.redhat.com/browse/SAT-18549

PRT test Cases example

Requires SatelliteQE/airgun#1615

trigger: test-robottelo
pytest: tests/foreman/ui/test_capsulecontent.py -k reclaim_space_warning
airgun: 1615

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 30, 2024
@vsedmik vsedmik self-assigned this Oct 30, 2024
@vsedmik vsedmik requested a review from a team as a code owner October 30, 2024 17:23
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 30, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_capsulecontent.py -k reclaim_space_warning
airgun: 1615

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9191
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_capsulecontent.py -k reclaim_space_warning --external-logging
Test Result : ========== 1 passed, 1 deselected, 14 warnings in 1310.18s (0:21:50) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 30, 2024
LadislavVasina1
LadislavVasina1 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, seems legit

chris1984
chris1984 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the commented steps and assertions look fine. PRT passed too.

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 31, 2024
@vsedmik vsedmik merged commit 4fa06b4 into SatelliteQE:master Oct 31, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
@vsedmik @web-flow
Add a test case for the reclaim space warning hiding (#16821)
420889d 
(cherry picked from commit 4fa06b4)
@Satellite-QE Satellite-QE mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@vsedmik vsedmik

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @chris1984 @LadislavVasina1