Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] TFA fix for discovery plugin #16128

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[6.16.z] TFA fix for discovery plugin #16128

merged 1 commit into from
Aug 29, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15783

The failure occurred because the code was deleting the discovery rule, and then attempting to read from the deleted table using the read_all() method. To resolve this issue, I added the read_after_del() method, which reads the page message after a rule is deleted or if there are no more tables.

Dependent PR: SatelliteQE/airgun#1480

@amolpati30 @web-flow
TFA fix for discovery plugin (#15783)
cfee537 
fixed in discoveryrule assertion

update in test

(cherry picked from commit 95906c1)
@Satellite-QE Satellite-QE requested a review from a team as a code owner August 29, 2024 06:02
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Aug 29, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveryrule.py -k 'crud_with_non_admin_user or end_to_end'
airgun: 1480

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Aug 29, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8362
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_discoveryrule.py -k crud_with_non_admin_user or end_to_end --external-logging
Test Result : =========== 2 passed, 2 deselected, 49 warnings in 949.53s (0:15:49) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Aug 29, 2024
@Satellite-QE Satellite-QE merged commit b68291e into 6.16.z Aug 29, 2024
17 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-95906c1b0e6a32719f3e6bd021c922058b6b0fbc branch August 29, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amolpati30 amolpati30

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @amolpati30