Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] Add end-to-end test for facts #15888

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15818

Problem Statement

Missing end-to-end scenario for facts
Existing implementation of get_facts() method splits the string on colon. With RHEL9, we have fact values which contains colon like 'lscpu.vulnerability_spec_rstack_overflow: Vulnerable: Safe RET, no microcode'. This raises Value error ``ValueError: too many values to unpack (expected 2)`.

Solution

Added e2e for facts
Updated the code to split the string on the first colon and treat the first half as key and rest of it as value.

Related Issues

@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Aug 8, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end
ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '9'

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Aug 8, 2024
@Satellite-QE Satellite-QE merged commit 22819ef into 6.14.z Aug 8, 2024
16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.14.z-f2d67d3b73fe3430c968d401c87b80371b73fb12 branch August 8, 2024 11:42
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8027
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_facts_end_to_end --external-logging
Test Result : =========== 1 passed, 8 deselected, 21 warnings in 916.65s (0:15:16) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants