Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate bookmark negative test fix #14232

Merged
merged 1 commit into from
Mar 20, 2024
Merged

duplicate bookmark negative test fix #14232

merged 1 commit into from
Mar 20, 2024

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Mar 1, 2024

Problem Statement

With SatelliteQE/airgun#1200 in, another problem uncovered in bookmarks. Trying to create a bookmark with already existing name doesn't raise exception in old style dialog (wontfix bz 1992652), it does so in the new style dialog (different one in stream than in 6.x runs). Affects ~20 tests

Solution

this pr attempts to cover all the cases

@pondrejk pondrejk added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 1, 2024
@pondrejk pondrejk self-assigned this Mar 1, 2024
@pondrejk pondrejk requested a review from a team as a code owner March 1, 2024 10:23
@pondrejk
Copy link
Contributor Author

pondrejk commented Mar 1, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5911
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name --external-logging
Test Result : = 10 failed, 28 passed, 156 deselected, 138 warnings, 1 error in 2309.84s (0:38:29) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 1, 2024
@pondrejk
Copy link
Contributor Author

pondrejk commented Mar 1, 2024

needs #14242 for full pass

lhellebr
lhellebr reviewed Mar 5, 2024
View reviewed changes
tests/foreman/ui/test_bookmarks.py Outdated
# wontfix, but new style dialog raises error, both situations occur
try:
ui_lib.create_bookmark({'name': bookmark.name, 'query': query, 'public': True})
except (DisabledWidgetError, NoSuchElementException):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So which dialogue will be used? Shouldn't we expect one of them? Shouldn't we expect an exception depending on what dialogue is being used? This looks too vague.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So which dialogue will be used?

@lhellebr Hm, I didn't find a way to easily establish that, from the airgun point of view, they are the same. The differentiator is the behavior when trying to save bookmark with existing name

Shouldn't we expect an exception depending on what dialogue is being used? This looks too vague.

In a way, I'm doing just that. If it doesn't raise, then I assume old style dialog and do additional checks to make sure duplicate stuff wasn't created.

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6019
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name --external-logging
Test Result : = 6 failed, 30 passed, 1 skipped, 156 deselected, 124 warnings, 2 errors in 2192.76s (0:36:32) =

@pondrejk pondrejk requested a review from a team as a code owner March 13, 2024 09:14
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name

1 similar comment
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6040
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name --external-logging
Test Result : = 28 failed, 8 passed, 1 skipped, 156 deselected, 119 warnings, 2 errors in 1907.00s (0:31:47) =

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6041
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name --external-logging
Test Result : = 28 failed, 8 passed, 1 skipped, 156 deselected, 118 warnings, 2 errors in 1921.89s (0:32:01) =

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6052
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_bookmarks.py -k test_negative_create_with_duplicate_name --external-logging
Test Result : = 8 failed, 28 passed, 1 skipped, 156 deselected, 124 warnings, 2 errors in 2520.19s (0:42:00) =

lhellebr
lhellebr approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed this personally and the way it is now looks good

@pondrejk pondrejk merged commit e44a553 into SatelliteQE:master Mar 20, 2024
6 of 8 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
@pondrejk @web-flow
duplicate bookmark negative test fix (#14232)
d5c21a1 
(cherry picked from commit e44a553)
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
@pondrejk @web-flow
duplicate bookmark negative test fix (#14232)
39b7c0b 
(cherry picked from commit e44a553)
This was referenced Mar 20, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
@pondrejk @web-flow
duplicate bookmark negative test fix (#14232)
8dcfbac 
(cherry picked from commit e44a553)
@Satellite-QE Satellite-QE mentioned this pull request Mar 20, 2024
Merged
pondrejk added a commit that referenced this pull request Mar 20, 2024
@Satellite-QE @pondrejk
[6.15.z] duplicate bookmark negative test fix (#14453)
246b2a7 
duplicate bookmark negative test fix (#14232)

(cherry picked from commit e44a553)

Co-authored-by: Peter Ondrejka <[email protected]>
pondrejk added a commit that referenced this pull request Mar 20, 2024
@Satellite-QE @pondrejk
[6.14.z] duplicate bookmark negative test fix (#14454)
4741463 
duplicate bookmark negative test fix (#14232)

(cherry picked from commit e44a553)

Co-authored-by: Peter Ondrejka <[email protected]>
pondrejk added a commit that referenced this pull request Mar 20, 2024
@Satellite-QE @pondrejk
[6.13.z] duplicate bookmark negative test fix (#14452)
ddbcd5a 
duplicate bookmark negative test fix (#14232)

(cherry picked from commit e44a553)

Co-authored-by: Peter Ondrejka <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@pondrejk @shweta83
duplicate bookmark negative test fix (SatelliteQE#14232)
467f543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhellebr lhellebr lhellebr approved these changes

Assignees

@pondrejk pondrejk

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pondrejk @Satellite-QE @lhellebr