Update fill method logic for button values #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColeHiggins2
added
PF4
sambible
approved these changes
Jan 8, 2025
chris1984
approved these changes
Jan 8, 2025
LadislavVasina1
approved these changes
Jan 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
(cherry picked from commit 47cc116)
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a thorough debugging session. It was discovered that when a user selects a new LCE, the "edit" button disappears and then requires and additional "fill" and "save" action. This is the case for PF4 as well.
This was introduced by a logic change here: #939
If you think this looks gross... IT IS. But I want to clarify that we cannot add any additional parameters/arguments to the fill method and we have nothing to really iterate over. So if you have any suggestions on how to make this look pretty im all ears :)