Add support for viewing the needs_publish banner in the cv index page… #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sambible To which branches do you want this PR to be merged? |
jameerpathan111
requested changes
Dec 12, 2024
Comment on lines
+68
to
+80
| view = self.navigate_to(self, 'All') | ||
| self.browser.plugin.ensure_page_safe(timeout='5s') | ||
| view.wait_displayed() | ||
| if not view.table.is_displayed: | ||
| # no table present, no CVs in this Org | ||
| return None | ||
| view.search(cv_name) | ||
| view.table[0][6].widget.item_select('Publish') | ||
| view = ContentViewVersionPublishView(self.browser) | ||
| is_displayed = view.publish_alert.is_displayed | ||
| view.cancel_button.click() | ||
| return is_displayed | ||
|
|
There was a problem hiding this comment.
Suggested change
| view = self.navigate_to(self, 'All') | |
| self.browser.plugin.ensure_page_safe(timeout='5s') | |
| view.wait_displayed() | |
| if not view.table.is_displayed: | |
| # no table present, no CVs in this Org | |
| return None | |
| view.search(cv_name) | |
| view.table[0][6].widget.item_select('Publish') | |
| view = ContentViewVersionPublishView(self.browser) | |
| is_displayed = view.publish_alert.is_displayed | |
| view.cancel_button.click() | |
| return is_displayed | |
| view = self.navigate_to(self, 'Publish', entity_name=cv_name) | |
| return view.publish_alert.is_displayed |
@sambible could you try this and see if it does the same thing as you want to do here?
There was a problem hiding this comment.
Specifically, this is targeting a version of the publish popup that comes up when using the dropdown menu from the cv index page, 'Publish' navigates to a different version of this page.
synkd
approved these changes
Jan 16, 2025
chris1984
approved these changes
Jan 16, 2025
LadislavVasina1
approved these changes
Jan 17, 2025
jameerpathan111
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change adding an entity to check the banner on cv publish through cv index page, and support for the needs publish banner on cv publish popup