Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dynflow console output for host #1522

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Check dynflow console output for host #1522

merged 1 commit into from
Sep 26, 2024

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Aug 20, 2024 •
edited
Loading

  • When enabling debug mode on Satellite, the task is generating an output log for all hosts present on the Job.

  • The host execution log is showing the debug log for all hosts present on the inventory instead of just the expected host.

Solution : -

  • Below automation check the host execution log should show the debug log for expected host instead of the all host present in the inventory.

Dependent PR: SatelliteQE/robottelo#15918

@amolpati30 amolpati30 force-pushed the dynflow_console_log branch 2 times, most recently from b9ee98a to 20c0471 Compare August 20, 2024 17:21
@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches 6.13.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.14.z 6.15.z labels Aug 20, 2024
@amolpati30 amolpati30 force-pushed the dynflow_console_log branch from 20c0471 to e805cb2 Compare August 20, 2024 17:29
@amolpati30 amolpati30 mentioned this pull request Aug 20, 2024
Merged
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_debug_log_for_host
robottelo: 15918

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 364
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_debug_log_for_host --external-logging
Test Result : ========== 1 passed, 16 deselected, 37 warnings in 1596.86s (0:26:36) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Aug 20, 2024
@amolpati30 amolpati30 changed the title Check debug mode output for host Check dynflow console output for host Aug 20, 2024
@amolpati30 amolpati30 force-pushed the dynflow_console_log branch 8 times, most recently from 080e1e0 to 45fe577 Compare August 21, 2024 11:44
@amolpati30 amolpati30 force-pushed the dynflow_console_log branch 2 times, most recently from 58e93cb to 4a6c1e1 Compare August 26, 2024 17:31
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_debug_log_for_host
robottelo: 15918

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 379
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_debug_log_for_host --external-logging
Test Result : ========== 1 passed, 14 deselected, 35 warnings in 951.31s (0:15:51) ===========

@amolpati30 amolpati30 requested a review from a team August 29, 2024 05:14
LadislavVasina1
LadislavVasina1 requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good contribution, but I would make few changes in some function names.

Gauravtalreja1
Gauravtalreja1 reviewed Sep 2, 2024
View reviewed changes
airgun/views/task.py Outdated Show resolved Hide resolved
@amolpati30 amolpati30 marked this pull request as draft September 5, 2024 09:45
@amolpati30 amolpati30 marked this pull request as ready for review September 21, 2024 20:07
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleREX -k test_positive_ansible_job_with_verbose_stdout
robottelo: 15918

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 420
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleREX -k test_positive_ansible_job_with_verbose_stdout --external-logging
Test Result : =========== 1 passed, 9 deselected, 30 warnings in 960.89s (0:16:00) ===========

@omkarkhatavkar
Copy link

Overall good contribution, but I would make few changes in some function names.

@LadislavVasina1 can you review the pr again ?

@Gauravtalreja1 Gauravtalreja1 merged commit 0272100 into SatelliteQE:master Sep 26, 2024
8 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@amolpati30 @web-flow
added views and entities to fetch the dynflow console output (#1522)
39f98c8 
(cherry picked from commit 0272100)
This was referenced Sep 26, 2024
Merged
Closed
Closed
Closed
@amolpati30 amolpati30 mentioned this pull request Sep 27, 2024
Merged
This was referenced Sep 27, 2024
Merged
Merged
Merged
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Sep 27, 2024
@Satellite-QE @amolpati30
added views and entities to fetch the dynflow console output (#1522) (#…
9e40639 
…1570)

(cherry picked from commit 0272100)

Co-authored-by: amolpati30 <[email protected]>
This was referenced Sep 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@amolpati30 amolpati30

Labels
6.13.z 6.14.z 6.15.z 6.16.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amolpati30 @Satellite-QE @omkarkhatavkar @Gauravtalreja1 @LadislavVasina1