Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to additional div in taxonomy mismatch locator #1206

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Jan 29, 2024

An additional div was added in foreman 3.9 (6.15.z)

So the form locator has to be adapted.

before

 <div class="modal-body">
    <div id="content">
        <form class="form-horizontal well">

after

 <div class="modal-body">
    <div id="content">
      <div class="pf-c-page__main-section pf-m-light rails-table-toolbar">
        <form class="form-horizontal well">

@dosas dosas changed the title Adapt to additional div taxonomy mismatch locator Adapt to additional div in taxonomy mismatch locator Jan 29, 2024
dosas added a commit to ATIX-AG/airgun that referenced this pull request Jan 29, 2024
@omkarkhatavkar
Copy link

@sambible Can you please take a look ?

@omkarkhatavkar omkarkhatavkar added the CherryPick PR needs CherryPick to previous branches label Feb 6, 2024
dosas added a commit to ATIX-AG/airgun that referenced this pull request Feb 7, 2024
@LadislavVasina1 LadislavVasina1 added view Issues related to Views coverage 6.15.z locator Locator changes labels Feb 8, 2024
@LadislavVasina1 LadislavVasina1 self-requested a review February 8, 2024 09:27
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the validity of the locator on 6.15 and stream and the change is correct. ACK

@omkarkhatavkar
Copy link

Thanks @LadislavVasina1 doing this.

@omkarkhatavkar omkarkhatavkar merged commit 375de50 into SatelliteQE:master Feb 8, 2024
8 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
omkarkhatavkar pushed a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z CherryPick PR needs CherryPick to previous branches locator Locator changes view Issues related to Views coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants