Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_register_command to reflect new mandatory fields #1087

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Update get_register_command to reflect new mandatory fields #1087

merged 1 commit into from
Dec 19, 2023

Conversation

Gauravtalreja1
Copy link
Collaborator

Description

  • Update get_register_command to reflect new mandatory fields i.e ActivationKey, which was previously operating systems.
  • Make get_register_command work when no values are passed, required for default values validation and few negative tests.
  • Add locator for new_activation_key_link, which appears when no AK available in organization, and when there's single AK in organization, AK will be auto-selected in 6.15+

@Gauravtalreja1 Gauravtalreja1 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.15.z labels Dec 18, 2023
@Gauravtalreja1 Gauravtalreja1 self-assigned this Dec 18, 2023
This was referenced Dec 18, 2023
Merged
Merged
Merged
omkarkhatavkar
omkarkhatavkar approved these changes Dec 19, 2023
View reviewed changes
Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, 1 minor change

@Gauravtalreja1 Gauravtalreja1 force-pushed the update-get-register-command branch from 555e1cb to 4d9762d Compare December 19, 2023 09:28
@Gauravtalreja1 Gauravtalreja1 force-pushed the update-get-register-command branch from 4d9762d to be6a7a4 Compare December 19, 2023 09:55
@adarshdubey-star
Copy link
Contributor

Good work @Gauravtalreja1

@adarshdubey-star adarshdubey-star merged commit 064530e into SatelliteQE:master Dec 19, 2023
9 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@Gauravtalreja1 @web-flow
Update get_register_command to reflect new mandatory fields (#1087)
6eb1abf 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 064530e)
This was referenced Dec 19, 2023
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the update-get-register-command branch December 19, 2023 14:17
adarshdubey-star pushed a commit that referenced this pull request Dec 19, 2023
@Satellite-QE @Gauravtalreja1
Update get_register_command to reflect new mandatory fields (#1087) (#…
f45bb26 
…1094)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 064530e)

Co-authored-by: Gaurav Talreja <[email protected]>
Gauravtalreja1 added a commit to Gauravtalreja1/airgun that referenced this pull request Dec 20, 2023
@Gauravtalreja1
Update get_register_command to reflect new mandatory fields (Satellit…
11ef549 
…eQE#1087)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 064530e)
Signed-off-by: Gaurav Talreja <[email protected]>
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Dec 20, 2023
Merged
adarshdubey-star pushed a commit that referenced this pull request Dec 20, 2023
@Gauravtalreja1
Update get_register_command to reflect new mandatory fields (#1087) (#…
04d3a4c 
…1095)

(cherry picked from commit 064530e)

Signed-off-by: Gaurav Talreja <[email protected]>
damoore044 pushed a commit to damoore044/airgun that referenced this pull request Jan 12, 2024
@Gauravtalreja1 @damoore044
Update get_register_command to reflect new mandatory fields (Satellit…
a4ed154 
…eQE#1087)

Signed-off-by: Gaurav Talreja <[email protected]>
pondrejk pushed a commit to pondrejk/airgun that referenced this pull request Mar 19, 2024
@Gauravtalreja1 @pondrejk
Update get_register_command to reflect new mandatory fields (Satellit…
97f0866 
…eQE#1087)

Signed-off-by: Gaurav Talreja <[email protected]>
@pondrejk pondrejk mentioned this pull request Mar 19, 2024
Merged
omkarkhatavkar pushed a commit that referenced this pull request Mar 22, 2024
@pondrejk @Gauravtalreja1
Update get_register_command to reflect new mandatory fields (#1087) (#…
b016c0a 
…1293)

Signed-off-by: Gaurav Talreja <[email protected]>
Co-authored-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarshdubey-star adarshdubey-star adarshdubey-star approved these changes

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.15.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @adarshdubey-star @omkarkhatavkar @LadislavVasina1