-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CV UI - Add versions screen, and capability to search/read all tables #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambible
added
CherryPick
PR needs CherryPick to previous branches
6.13.z
6.14.z
6.15.z
labels
Dec 15, 2023
sambible
requested review from
ColeHiggins2,
vijaysawant,
vsedmik,
damoore044 and
a team
December 15, 2023 17:25
vsedmik
reviewed
May 7, 2024
vsedmik
approved these changes
May 10, 2024
damoore044
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
omkarkhatavkar
approved these changes
May 14, 2024
@sambible Looks overall good, just a smaller non-blocking comment. |
lhellebr
approved these changes
May 14, 2024
vijaysawant
requested changes
May 16, 2024
Use single quotation instead of double Co-authored-by: vijay sawant <[email protected]>
vijaysawant
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
This was referenced Jun 3, 2024
damoore044
pushed a commit
to damoore044/airgun
that referenced
this pull request
Jun 22, 2024
…SatelliteQE#1083) * Add versions screen, and capability to search/read all tables * Change field name and remove commented field * Better locator for versions tab * Apply suggestions from code review Use single quotation instead of double Co-authored-by: vijay sawant <[email protected]> --------- Co-authored-by: vijay sawant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airgun Support for the Versions screen of CV UI - supports reading/searching all tables.
Robottelo PR exercising this: SatelliteQE/robottelo#13478