Refactor D3 Map to Support Both Rate Charts and Unknowns Charts #3949
Conversation
…r isMobile property
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
eriwarr
changed the title
# Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> - adds feature flag - conditionally adds "Gun Deaths" as new dropdown topic - adds handling for gun deaths from CHR to AHR provider (maybe should be gun violence? Maybe we should rethink the provider structure overall) ## Has this been tested? How? e2e tests still passing. manually confirmed only working with flag enabled on county-level data ## Screenshots (if appropriate)   ## Types of changes (leave all that apply) - New content or feature ## New frontend preview link is below in the Netlify comment 😎
removed unused file fix npm security issue
There was a problem hiding this comment.
looks like there are some frontend test errors happening; maybe typescript errors?
also, the highest/lowest mode for CAWP is strange where it's assigning colors correctly to the territory bubbles, but switched for the states (yellow should be GOOD rates of women in gov, but it's showing the states with the worst rates 0% as yellow... only in highest/lowest but not in normal view)
Colors aren't perfectly synced with the legend yet, when expanding into extremes mode, you can see Oklahoma should have the lightest yellow color based on its rate, but it's shown as a slightly darker orange. almost like it's recalculating the color scale from only the remaining states but keeping the legend scale across ALL data points. I think either way is fine, like if the extremes mode gets its newly calculated scale, but we need to make sure the legend will match it accurately
There was a problem hiding this comment.
awesome work! thanks for cleaning everything up and improving the legends across the board. There are some weird things still around the color scheme typing, but I think we'll be able to clean those up and simplify once we've totally switched over to the new d3 stuff (and fully removed vega)
| const mapScheme = | ||
| typeof props.mapConfig.scheme === 'string' | ||
| ? props.mapConfig.scheme | ||
| : 'darkgreen' | ||
|
|
There was a problem hiding this comment.
this feels weird; will we be able to remove this once we have fully migrated from vega to d3 ?
Description and Motivation
This PR refactors the D3 map implementation to support both rate charts and unknowns charts. Key changes include:
renderMap.tsxto handle different chart types dynamically.getFillColorto adjust colors based on extremesMode for better data visualization.createColorScaleto internally determine the appropriate scale type (sequentialSymlog vs. quantileSequential).Has this been tested? How?
Tested locally
Screenshots (if appropriate)
Types of changes
New frontend preview link is below in the Netlify comment 😎