Skip to content

Commit

Permalink
Merge pull request #290 from Sanketika-Obsrv/ingestion-spec-fix
Browse files Browse the repository at this point in the history
Ingestion spec fix having blank spaces
  • Loading branch information
HarishGangula authored Dec 3, 2024
2 parents 244a9f1 + 3ed1018 commit bb88954
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions api-service/src/services/CloudServices/AWSStorageService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@ export class AWSStorageService implements ICloudService {
const accessKeyId = _.get(config, "identity")
const secretAccessKey = _.get(config, "credential")
const endpoint = _.get(config, "endpoint")
const s3ForcePathStyle = _.get(config, "s3ForcePathStyle")
const configuration: any = { region, credentials: { accessKeyId, secretAccessKey } }
if(endpoint) {
configuration.endpoint = endpoint;
}
if (s3ForcePathStyle) {
configuration.s3ForcePathStyle = s3ForcePathStyle;
}
try {
this.client = new S3Client(configuration);
}
Expand Down
4 changes: 2 additions & 2 deletions api-service/src/services/TableGenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ class BaseTableGenerator {
const properties = this.flattenSchema(denormDataset.data_schema, type);
const transformProps = _.map(properties, (prop) => {
_.set(prop, "name", _.join([denormField.denorm_out_field, prop.name], "."));
_.set(prop, "expr", _.replace(prop.expr, "$", "$." + denormField.denorm_out_field));
_.set(prop, "expr", _.replace(prop.expr, "$", "$." + `['${denormField.denorm_out_field}']`));
return prop;
});
dataFields.push(...transformProps);
}
}
if (!_.isEmpty(transformations_config)) {
const transformationFields = _.map(transformations_config, (tf) => ({
expr: "$." + tf.field_key,
expr: "$." + `['${tf.field_key}']`,
name: tf.field_key,
data_type: tf.transformation_function.datatype,
arrival_format: tf.transformation_function.datatype,
Expand Down

0 comments on commit bb88954

Please sign in to comment.