hdiutils fails on macos-13 build

[SanderVocke]

The build step on macos-13 runners, as defined in build_and_test.yml GitHub Actions script, fails on creating .dmg images with hdiutil.

hdiutil is indirectly used in our build scripts by using the create-dmg tool.

Online reports have stated that dmgbuild does seem to work stably on these runners.

Change the github actions scripts to use dmgbuild instead of create-dmg to create a dmg application image. If possible keep the user experience the same, but this is not necessary as long as a working installable dmg is created.

Note that currently, create-dmg is installed in .github/actions/prepare_build_macos/action.yml, and used in .github/actions/build_package/action.yml. These places are likely where changes will need to be made.

[github-actions]

OpenHands started fixing the issue! You can monitor the progress here.

[github-actions]

A potential fix has been generated and a draft PR #476 has been created. Please review the changes.

[SanderVocke]

@openhands-agent

Please try again but disregard the potential solution of switching to dmgbuild. Instead, wrap the create-dmg command in a retry loop for max 10 iterations, hoping it will eventually succeed.

An example of how this can be done:

          # FIXME: Undo this overengineered crap once the following issue gets figured out:
          #        https://github.com/actions/runner-images/issues/7522
          max_tries=10
          i=0
          until create-dmg \
                  --no-internet-enable \
                  --format ULFO \
                  --background ../packaging/macos/dmg-background.png \
                  --hide-extension 'Notes Better.app' \
                  --icon 'Notes Better.app' 180 170 \
                  --icon-size 160 \
                  --text-size 12 \
                  --volname Notes \
                  --volicon ../src/images/notes_icon.icns \
                  --window-size 660 400 \
                  --app-drop-link 480 170 \
                  '${{ steps.vars.outputs.file_name }}' \
                  'Notes Better.app'
          do
              if [ $i -eq $max_tries ]
              then
                  echo 'Error: create-dmg did not succeed even after 10 tries.'
                  exit 1
              fi
              i=$((i+1))
          done

[github-actions]

OpenHands started fixing the issue! You can monitor the progress here.

[github-actions]

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-475-try2' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.