Skip to content

Commit

Permalink
Fix issue #475: hdiutils fails on macos-13 build
Browse files Browse the repository at this point in the history
  • Loading branch information
openhands-agent committed Dec 9, 2024
1 parent 49969bb commit 275b257
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 13 deletions.
12 changes: 1 addition & 11 deletions .github/actions/build_package/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -185,17 +185,7 @@ runs:
DMGFILE=shoopdaloop-${{ env.SHOOP_GIT_REV }}.$(uname -m).dmg
RELEASE_DMGFILE=shoopdaloop-${{ env.SHOOP_VERSION }}.$(uname -m).dmg
cp -r ${{ env.PORTABLE_DIR }} shoopdaloop.app
create-dmg \
--volname "ShoopDaLoop" \
--volicon "distribution/macos/icon.icns" \
--window-pos 200 120 \
--window-size 800 400 \
--icon-size 100 \
--icon "shoopdaloop.app" 200 190 \
--hide-extension "shoopdaloop.app" \
--app-drop-link 600 185 \
$DMGFILE \
shoopdaloop.app
dmgbuild -s distribution/macos/dmg_settings.py "ShoopDaLoop" $DMGFILE
cp $DMGFILE $RELEASE_DMGFILE
echo "BUILT_PACKAGE=$DMGFILE" | tee -a $GITHUB_ENV
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/prepare_build_macos/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
brew install ninja libsndfile libtool automake autoconf cmake
brew install jack liblo coreutils
brew install [email protected]
brew install create-dmg
brew install dmgbuild
# Install Python packages
$PIP install --upgrade pip build
Expand Down Expand Up @@ -55,4 +55,4 @@ runs:
echo "CMAKE_INCLUDE_PATH=$CMAKE_INCLUDE_PATH:${{ github.workspace }}/includes:${{ github.workspace }}/boost/boost/include" | tee -a $GITHUB_ENV
echo "LDFLAGS=$LDFLAGS -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib" | tee -a $GITHUB_ENV
echo "CFLAGS=$CFLAGS -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include -I/Users/runner/work/shoopdaloop/shoopdaloop/boost/boost/include" | tee -a $GITHUB_ENV
echo "CPPFLAGS=$CPPFLAGS -isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include -I/Users/runner/work/shoopdaloop/shoopdaloop/boost/boost/include" | tee -a $GITHUB_ENV
echo "CPPFLAGS=$CPPFLAGS -isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include -I/Users/runner/work/shoopdaloop/shoopdaloop/boost/boost/include" | tee -a $GITHUB_ENV
14 changes: 14 additions & 0 deletions distribution/macos/dmg_settings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# dmg_settings.py for dmgbuild

application = {
'app': 'shoopdaloop.app',
'icon': 'distribution/macos/icon.icns',
'background': 'builtin-arrow',
'icon_locations': {
'shoopdaloop.app': (200, 190),
'Applications': (600, 185)
},
'window_rect': ((200, 120), (800, 400)),
'hide_extensions': ['shoopdaloop.app'],
'format': 'UDZO'
}

0 comments on commit 275b257

Please sign in to comment.