-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS/DriverKit through MacVFN #10
Open
Baekalfen
wants to merge
23
commits into
SamsungDS:main
Choose a base branch
from
Baekalfen:driverkit_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,638
−815
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
abab907
mmio: convert calls of 'addr + offset' to 'base-addr, offset'
Baekalfen 1982a33
support/linux: move linux mem.c to src/support/platform/linux/
Baekalfen 37b5cbf
support/linux: prepartory work of moving log, mem, mmio, mutex header…
Baekalfen 3f8f21e
support/macos: add macos replacement for byteswap.h
Baekalfen cedbf40
support/macos: add macos replacement for errno.h
Baekalfen c698007
support/macos: added include/.../platform/macos/log.h
Baekalfen b09b63c
support/macos: added include/.../platform/macos/mem.h
Baekalfen 0e640ea
support/macos: added include/.../platform/macos/mmio.h
Baekalfen 6a75519
support/macos: added include/.../platform/macos/mutex.h
Baekalfen b7fbecc
misc/cpp: add explicit cast of void* and change string concat to acco…
Baekalfen d81e69f
gitignore: crc64table.h and config.h
Baekalfen ff1b9e6
src/iommu/context.h: Add include guard
Baekalfen 91b3142
misc: reduce includes, add C++ ifdef
Baekalfen da24e66
iommu/iova: dma_map, iova_map_add, dma_unmap takes iova_mapping
Baekalfen 45be927
skiplist: replace rand() with arc4random() as it's not present on macOS
Baekalfen a961d1a
skiplist: Add include guard
Baekalfen 290dcd4
nvme_wait_rdy: timeout for macOS
Baekalfen 3b4bae1
nvme_cq_wait_cqes: timeout for macOS and counting ticks
Baekalfen 1c48f71
nvme/core: add serial to nvme_ctrl
Baekalfen 87ba60d
pgmap/iommu: refactor for opaque pointers
Baekalfen 3b111dd
macos: DriverKit core backend
Baekalfen e2144c2
misc/log: change logging on unrecoverable errors
Baekalfen 934f841
ci/macos: add macOS build process
Baekalfen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
nvme/core: add serial to nvme_ctrl
Added serial string to nvme_ctrl to be able to identify the device. This value is copied from the already issued identify during nvme_init. Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
commit 1c48f71fa5e9eb34e3f21b73f7a0df5990e495b5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bloats
struct nvme_ctrl
and it does not seem to be used in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I had put something in the commit message. It's for enumeration in xNVMe. MacVFN reads this serial and applies it to its name in macOS's "IO registry" of devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but it belongs in MacVFN then.