Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update escargot submodule #63

Merged
merged 1 commit into from
Oct 24, 2023
Merged

chore: update escargot submodule #63

merged 1 commit into from
Oct 24, 2023

Conversation

clover2123
Copy link
Contributor

No description provided.

@clover2123
Copy link
Contributor Author

Note) test/parallel/test-process-env-tz.js is additionally skipped in this patch because the latest Escargot version finds and adopts the system time zone.
But the old (origin) Escargot sets the default time zone. From that, the test file just decides that the engine is using an old time zone and skips the test.
In the recent Escargot version, it sets the time zone based on the system, however, following test code is not working which sets a new time zone. So, this makes an error after execution.

process.env.TZ = 'Europe/Amsterdam'

@clover2123 clover2123 marked this pull request as ready for review October 24, 2023 07:49
Copy link
Contributor

@hs0225 hs0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hs0225 hs0225 merged commit ecd030d into Samsung:main Oct 24, 2023
5 checks passed
@clover2123 clover2123 deleted the pr2 branch October 24, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants