os/driver/input/ist415: Change to power off when touch disabling #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add the ist415_forced_release function when you turn off the ist415 power. |
ewoodev
force-pushed
the
WORK-250225_ist415
branch
from
37c52fb to
5db5b60
Compare
Taejun-Kwon
reviewed
Feb 26, 2025
os/drivers/input/ist415.c
Outdated
| @@ -568,6 +573,11 @@ static int ist415_resume_device(struct touchscreen_s *upper) | |||
| ASSERT(get_errno() == EINTR); | |||
| } | |||
|
|
|||
| if (dev->forcedoff) { | |||
| sem_post(&dev->sem); | |||
| return EPERM; | |||
There was a problem hiding this comment.
EPERM is tightly related to permission, so I think ESHUTDOWN or ENXIO is good for this situation, I prefer ESHUTDOWN
There was a problem hiding this comment.
Thank you for suggestion. Updated
Taejun-Kwon
reviewed
Feb 26, 2025
|
|
||
| if (dev->forcedoff) { | ||
| ist415_power_off(dev); | ||
| } else if (dev->suspend) { |
There was a problem hiding this comment.
if both of forceoff & suspend never set as true, I think you can define enum regarding state and use dev->state instead of these 3 states.
Change to tunr off ist415 power when touch is disabled from apps for reduce power consumption. Signed-off-by: eunwoo.nam <[email protected]>
ewoodev
force-pushed
the
WORK-250225_ist415
branch
from
5db5b60 to
7d339fb
Compare
| @@ -568,6 +573,11 @@ static int ist415_resume_device(struct touchscreen_s *upper) | |||
| ASSERT(get_errno() == EINTR); | |||
| } | |||
|
|
|||
| if (dev->forcedoff) { | |||
There was a problem hiding this comment.
How about checking this at start of the function? Then, you don't need to take the sem.
| @@ -534,6 +534,11 @@ static int ist415_suspend_device(struct touchscreen_s *upper) | |||
| ASSERT(get_errno() == EINTR); | |||
| } | |||
|
|
|||
| if (dev->forcedoff) { | |||
sunghan-chang
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to tunr off ist415 power when touch is disabled from apps for reduce power consumption.