Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Revise to include compile flags #8549

Merged
merged 1 commit into from
Mar 3, 2022
Merged

[infra] Revise to include compile flags #8549

merged 1 commit into from
Mar 3, 2022
+39 −0

Conversation

seanshpark
Copy link
Contributor

This will revise CMakeLists to include compilation flags depending on target platform.

ONE-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@gmail.com

@seanshpark
Copy link
Contributor Author

For #8379, from draft #8407

hyunsik-yoon
hyunsik-yoon previously approved these changes Mar 2, 2022
View reviewed changes
@seanshpark
Copy link
Contributor Author

18:50:28 CMake Error at cmake/ApplyCompileFlags.cmake:13 (include):
18:50:28 include could not find load file:
18:50:28
18:50:28 /opt/jenkins_slave/workspace/nnfw/master/pr-nncc-debug@2/infra/nncc/cmake/buildtool/config/config_x86_64-linux.cmake
18:50:28 Call Stack (most recent call first):
18:50:28 CMakeLists.txt:166 (include)

@seanshpark seanshpark added the PR/NO MERGE Please don't merge. I'm still working on this :) label Mar 2, 2022
@seanshpark
Copy link
Contributor Author

seanshpark commented Mar 2, 2022 •
edited
Loading

I think I need to add onfig_x86_64-linux.cmake -_-;;;
Or include only when toolchain file is given file exist

@seanshpark seanshpark force-pushed the infra_nncc_compflags branch from 1bdddd4 to df215cf Compare March 2, 2022 10:08
@seanshpark seanshpark removed the PR/NO MERGE Please don't merge. I'm still working on this :) label Mar 2, 2022
@seanshpark seanshpark requested a review from hyunsik-yoon March 2, 2022 10:17
@seanshpark
[infra] Revise to include compile flags
37d6617 
This will revise CMakeLists to include compilation flags depending on target platform.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
@seanshpark seanshpark force-pushed the infra_nncc_compflags branch from df215cf to 37d6617 Compare March 2, 2022 10:30
@seanshpark
Copy link
Contributor Author

PTAL

hseok-oh
hseok-oh approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark
Copy link
Contributor Author

ping @chunseoklee

@seanshpark seanshpark merged commit 7d96bf0 into Samsung:master Mar 3, 2022
@seanshpark seanshpark deleted the infra_nncc_compflags branch March 3, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunseoklee chunseoklee

@hseok-oh hseok-oh

@hyunsik-yoon hyunsik-yoon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seanshpark @chunseoklee @hseok-oh @hyunsik-yoon