[infra] Fix order of stamp generation for ExternalBuild_CMake

[seanshpark]

This will fix order of stamp generation after external cmake build is success.

ONE-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

[seanshpark]

For #8379, from draft #8407

This is to make BUILD_STAMP after build is success, where it was created before the build.

[hseok-oh]

It was designed to not retry build when failed.

ONE/infra/cmake/modules/ExternalBuildTools.cmake

Lines 27 to 33 in 3ce763e

	# NOTE Do NOT retry build once it fails
	if(EXISTS ${BUILD_STAMP_PATH})
	file(READ ${BUILD_STAMP_PATH} READ_IDENTIFIER)
	if("${READ_IDENTIFIER}" STREQUAL "${PKG_IDENTIFIER}")
	return()
	endif("${READ_IDENTIFIER}" STREQUAL "${PKG_IDENTIFIER}")
	endif(EXISTS ${BUILD_STAMP_PATH})

Please update above comment.

[seanshpark]

OK, it was by design...
I had a problem while make a cross build of external project and had to remove the stamp to make it retry the build.
So I think by design is like while development, the developer should manually clean the stamp.
Once the development is done, external build should not break in normal cases.
If it does break, then there is some critical situation and should skip retry as it will may always fail...

[seanshpark]

I think leaving as-is would be better :)