Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Provide CMAKE_TOOLCHAIN_FILE for external #8482

Merged

Conversation

seanshpark
Copy link
Contributor

This will provide CMAKE_TOOLCHAIN_FILE for external CMake projects if defined.

ONE-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

This will provide CMAKE_TOOLCHAIN_FILE for external CMake projects if defined.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
@seanshpark
Copy link
Contributor Author

For #8379, from draft #8407

@hyunsik-yoon
Copy link
Contributor

Can I ask a question? In draft, I saw toolchain file for x86.
I wonder if x86 toolchain file can also be used for CMAKE_TOOLCHAIN_FILE.

Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark
Copy link
Contributor Author

I wonder if x86 toolchain file can also be used for CMAKE_TOOLCHAIN_FILE.

I think yes but I think I won't land the file for x86_64 :)

@seanshpark seanshpark merged commit 7802d36 into Samsung:master Feb 22, 2022
@seanshpark seanshpark deleted the infra_external_cmake_toolchain branch February 22, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants