[circle-mlir/tools-test] Introduce gen-onnx with Add models #14732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will introduce gen-onnx test tool to generate onnx models for testing from pytorch source code with unit test Add models. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
zetwhite
reviewed
Feb 25, 2025
Comment on lines
+23
to
+24
| set(PYTORCH_UNIT_PATH "${CMAKE_SOURCE_DIR}/models/unit") | ||
| set(PYTORCH_NET_PATH "${CMAKE_SOURCE_DIR}/models/net") |
There was a problem hiding this comment.
Is models/net going to be introduced later?
I'd like to understand the difference between units and net. How do we determine which module belongs to units or net?
There was a problem hiding this comment.
Is models/net going to be introduced later?
Yes
difference between units and net
unit is for single Op, net is for multiple Ops; a network for Ops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will introduce gen-onnx test tool to generate onnx models for testing
from pytorch source code with unit test Add models.