[luci/pass] Introduce ArrayIndex helper #14565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's introduce Array4DIndex to help calculating 4D array index. ONE-DCO-Signed-off-by: Dayoung Lee <[email protected]>
seanshpark
reviewed
Jan 20, 2025
seanshpark
reviewed
Jan 20, 2025
seanshpark
reviewed
Jan 20, 2025
seanshpark
reviewed
Jan 20, 2025
This comment was marked as outdated.
This comment was marked as outdated.
dayo09
added
PR/ready for review
dayo09
commented
Jan 20, 2025
dayo09
commented
Jan 20, 2025
seanshpark
reviewed
Jan 20, 2025
| return i0 * _strides[0] + i1 * _strides[1] + i2 * _strides[2] + i3 * _strides[3]; | ||
| } | ||
|
|
||
| uint32_t Array4DIndex::size(void) const { return _dim[0] * _dim[1] * _dim[2] * _dim[3]; } |
There was a problem hiding this comment.
this assumes all elements should be positive numbers.
you have assert(_strides[i] > 0); in ctor but this is only for debug version.
how about using throw as zero or negative seems to be invalid numbers.
There was a problem hiding this comment.
if we can change to throw, we can add one more negative test something like invalid_array_4d_NEG
There was a problem hiding this comment.
_dim is unsigned, so exception seems to be redundant.
There was a problem hiding this comment.
@jinevening It's right. I'll just add exception to check whether they are zero or not.
seanshpark
reviewed
Jan 20, 2025
jinevening
reviewed
Jan 21, 2025
jinevening
reviewed
Jan 21, 2025
jinevening
reviewed
Jan 21, 2025
Co-authored-by: Hyukjin Jeong <[email protected]> Co-authored-by: SaeHie Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's introduce Array4DIndex to help calculating 4D array index.
ONE-DCO-Signed-off-by: Dayoung Lee [email protected]
For #14552
Dr #14564
To extend the funtionality of
extend broadcast constpass, I introduce this helper.