-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onert/python] Introduce optimizer API #14543
Open
ragmani
wants to merge
2
commits into
Samsung:master
Choose a base branch
from
ragmani:onert/python/add_optimizers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
runtime/onert/api/python/package/experimental/train/optimizer/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
from .sgd import SGD | ||
from .adam import Adam | ||
from onert.native.libnnfw_api_pybind import trainable_ops | ||
|
||
__all__ = ["SGD", "Adam", "trainable_ops"] |
20 changes: 20 additions & 0 deletions
20
runtime/onert/api/python/package/experimental/train/optimizer/adam.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
from .optimizer import Optimizer | ||
|
||
|
||
class Adam(Optimizer): | ||
""" | ||
Adam optimizer. | ||
""" | ||
def __init__(self, learning_rate=0.001, beta1=0.9, beta2=0.999, epsilon=1e-7): | ||
""" | ||
Initialize the Adam optimizer. | ||
Args: | ||
learning_rate (float): The learning rate for optimization. | ||
beta1 (float): Exponential decay rate for the first moment estimates. | ||
beta2 (float): Exponential decay rate for the second moment estimates. | ||
epsilon (float): Small constant to prevent division by zero. | ||
""" | ||
super().__init__(learning_rate) | ||
self.beta1 = beta1 | ||
self.beta2 = beta2 | ||
self.epsilon = epsilon |
15 changes: 15 additions & 0 deletions
15
runtime/onert/api/python/package/experimental/train/optimizer/optimizer.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
from onert.native.libnnfw_api_pybind import trainable_ops | ||
|
||
|
||
class Optimizer: | ||
""" | ||
Base class for optimizers. Subclasses should implement the `step` method. | ||
""" | ||
def __init__(self, learning_rate=0.001, nums_trainable_ops=trainable_ops.ALL): | ||
""" | ||
Initialize the optimizer. | ||
Args: | ||
learning_rate (float): The learning rate for optimization. | ||
""" | ||
self.learning_rate = learning_rate | ||
self.nums_trainable_ops = nums_trainable_ops |
21 changes: 21 additions & 0 deletions
21
runtime/onert/api/python/package/experimental/train/optimizer/sgd.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
from .optimizer import Optimizer | ||
|
||
|
||
class SGD(Optimizer): | ||
""" | ||
Stochastic Gradient Descent (SGD) optimizer. | ||
""" | ||
def __init__(self, learning_rate=0.001, momentum=0.0): | ||
""" | ||
Initialize the SGD optimizer. | ||
Args: | ||
learning_rate (float): The learning rate for optimization. | ||
momentum (float): Momentum factor (default: 0.0). | ||
""" | ||
super().__init__(learning_rate) | ||
|
||
if momentum != 0.0: | ||
raise NotImplementedError( | ||
"Momentum is not supported in the current version of SGD.") | ||
self.momentum = momentum | ||
self.velocity = None | ||
zetwhite marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
step()
is deleted, this needs to be updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ragmani But I think this has to be fixed. That's why I didn't approve this PR yet.