Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/python] Modularize python binding code. #14529

Merged

Conversation

ragmani
Copy link
Contributor

@ragmani ragmani commented Jan 7, 2025

This commit modularizes the python binding code.

  • Decompose binding code into session and tensorinfo
  • Decompose files to session and tensorinfo

ONE-DCO-1.0-Signed-off-by: ragmani [email protected]

@ragmani ragmani requested a review from a team January 7, 2025 04:24
@ragmani
Copy link
Contributor Author

ragmani commented Jan 7, 2025

For #14505
Draft : #14492

This commit modularizes the python binding code.
  - Decompose binding code into session and tensorinfo
  - Decompose files to session and tensorinfo

ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
@ragmani ragmani force-pushed the onert/python/modularize_binding_code branch from ae0a4a9 to fb7b6c0 Compare January 7, 2025 04:37
@ragmani ragmani added the PR/ready for review It is ready to review. Please review it. label Jan 7, 2025
@@ -0,0 +1,38 @@
/*
* Copyright (c) 2023 Samsung Electronics Co., Ltd. All Rights Reserved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already exists. So I keep up the year.

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023 Samsung Electronics Co., Ltd. All Rights Reserved
* Copyright (c) 2025 Samsung Electronics Co., Ltd. All Rights Reserved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is created newly in this PR.

Copy link
Contributor

@seockho-kim seockho-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zetwhite zetwhite requested a review from a team January 8, 2025 01:08
@hseok-oh hseok-oh merged commit 863750a into Samsung:master Jan 8, 2025
9 checks passed
@ragmani ragmani deleted the onert/python/modularize_binding_code branch January 8, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants