[luci] Support scalar axis in SubstituteExpandDimsToReshapePass #14464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports scalar axis in SubstituteExpandDimsToReshapePass. ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
|
ExpandDims with scalar axis appears in grouped query attention. |
dayo09
reviewed
Dec 17, 2024
| { | ||
| _graph.init({16, 3, 1}, {16, 3, 1, 1}, 2); | ||
|
|
||
| _graph.scalar_axis(2); |
There was a problem hiding this comment.
IDK how it works, that,
This part is called in init and
_axis = luci::create_const_node<int32_t>(g(), loco::DataType::S32, {1}, axis);
_axis->name("axis");This part is called again,
_axis = luci::create_const_node<int32_t>(g(), loco::DataType::S32, {}, axis);
_axis->name("axis");Is the later node with scalar axis is overriding the previous dim1 node?
There was a problem hiding this comment.
Yes. It creates a new scalar node and replaces _axis with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports scalar axis in SubstituteExpandDimsToReshapePass.
ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]