Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Remove no-reorder from strict build #14463

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions infra/nncc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ include("cmake/ApplyCompileFlags.cmake")
###
add_library(nncc_common INTERFACE)
if(ENABLE_STRICT_BUILD)
# TODO Remove -Wno-reoder and -Wno-overloaded-virtual
target_compile_options(nncc_common INTERFACE -Werror -Wall -Wextra -Wno-reorder -Wno-overloaded-virtual)
# TODO Remove -Wno-overloaded-virtual
target_compile_options(nncc_common INTERFACE -Werror -Wall -Wextra -Wno-overloaded-virtual)
endif(ENABLE_STRICT_BUILD)

add_library(nncc_coverage INTERFACE)
Expand Down