[infra/onert] Disable ACL build as default #14453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables ACL build as default. It will be enabled when target is aarch32/64 and OS is android or linux. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
ys44kim
reviewed
Dec 15, 2024
| @@ -1,4 +1,7 @@ | |||
| # aarch64 android cmake options | |||
| # | |||
| option(BUILD_ARMCOMPUTE "Build ARM Compute from the downloaded source" ON) | |||
| option(DOWNLOAD_ARMCOMPUTE "Build ARM Compute from the downloaded source" ON) | |||
There was a problem hiding this comment.
It is DOWNLOAD_ARMCOMPUTE, but the description seems to be Build .... It would be better to change to Download..
Suggested change
| option(DOWNLOAD_ARMCOMPUTE "Build ARM Compute from the downloaded source" ON) | |
| option(DOWNLOAD_ARMCOMPUTE "Download ARM Compute source" ON) |
|
@ys44kim @ragmani @chunseoklee I updated help message. PTAL |
chunseoklee
approved these changes
Dec 16, 2024
ragmani
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables ACL build as default.
It will be enabled when target is aarch32/64 and OS is android or linux.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]