[onert/ggml] Don't specify arch on armv7l linux build #14436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It removes the specific arch on ggml cross armv7l linux build. Previously, ggml specifies -mfpu=neon-fp-armv8, which may cause illegal instruction signal during running ggml_quantize_row_q8_0, especially compiled with gcc-13 -On, where n = 1,2,3 on odroid xu4. (ARMv7 Cortex-A15). ONE-DCO-1.0-Signed-off-by: Sanggyu Lee <[email protected]>
glistening
commented
Dec 9, 2024
| @@ -1098,7 +1098,7 @@ if (CMAKE_OSX_ARCHITECTURES STREQUAL "arm64" OR | |||
| list(APPEND ARCH_FLAGS -mfpu=neon-vfpv4 -mno-unaligned-access -funsafe-math-optimizations) | |||
| else() | |||
| # Raspberry Pi 2 | |||
There was a problem hiding this comment.
Our target is not Raspberry Pi 2.
There was a problem hiding this comment.
Please add comment about custom fix.
Ex)
ONE/runtime/3rdparty/ggml/CMakeLists.txt
Line 232 in ab777f0
chunseoklee
previously approved these changes
Dec 9, 2024
glistening
force-pushed
the
dont_use_specific_arch_on_armv7l_ggml_build
branch
from
35689ed to
849250d
Compare
|
On Ubuntu 24.04 mate: After this patch, Before |
|
I also confirmed this PR working on my environment. |
|
@chunseoklee PTAL. Comment is updated as @hseok-oh requested. |
chunseoklee
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It removes the specific arch on ggml cross armv7l linux build. Previously, ggml specifies -mfpu=neon-fp-armv8, which may cause illegal instruction signal during running ggml_quantize_row_q8_0, especially compiled with gcc-13 -On, where n = 1,2,3 on odroid xu4. (ARMv7 Cortex-A15).
ONE-DCO-1.0-Signed-off-by: Sanggyu Lee [email protected]
Related: #14391