Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Clean up header include in nnfw_api_internal #14403

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Dec 3, 2024

This commit cleans up header includes in nnfw_api_internal.h/cc.

  • Reorder includes
  • Remove class/struct declaration in nnfw_api_internal.h
    • Use header include because it is not public header

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]

This commit cleans up header includes in nnfw_api_internal.h/cc.
- Reorder includes
- Remove class/struct declaration in nnfw_api_internal.h
  - Use header include because it is not public header

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Dec 3, 2024
@hseok-oh hseok-oh requested a review from a team December 3, 2024 03:58
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 8b1af60 into Samsung:master Dec 3, 2024
9 checks passed
@hseok-oh hseok-oh deleted the header_nnfw_api_internal branch December 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants